I suggest that for long-term code bug detection, you move all function
prototypes to a single *.h file now that BLACS,PBLAS, and ScaLapack are
merged. Many *.c files have internal prototypes or call functions that
return "int" with no prototype at all. Using a gcc based mpicc, and
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-declarations
Will find these. I ran across these when asked to look into building a
version with Fortran integers of size 8 bytes.
Also, you may want to remove code for non-MPI platforms (there is still some
UsingMpiBlacs ifdefs) and old bad MPI's and C (ifdef for __STDC__
ZeroByteTypeBug MpiBuffGood etc.), since you got rid of the TRANSCOMM Stuff,
I doubt anything needs these now.
|