Page 1 of 1

[CZ]GEJSV - real-> complex bugs

PostPosted: Mon Nov 16, 2015 7:52 am
by lawrence mulholland
In zgejsv.f

line 831: call to ZLASSQ should be call to DLASSQ
lines 910, 1839: call to ZLASCL should be call to DLASCL
line 810: call to IDAMAX should be call to IZAMAX
lines 1229,1524,1525,1526,1782,1783,1784: ZERO should be CZERO, ONE should be CONE

DFLOAT is a GNU extension, not Fortran standard
Should probably use generic MAX, MIN intrinsics rather than type specific DMAX1, DMIN1, MAX0, MIN0

Re: [CZ]GEJSV - real-> complex bugs

PostPosted: Mon Nov 16, 2015 7:53 pm
by Julien Langou
Dear Lawrence, Big thanks from Croatia from Zlatko and from us as well. Zlatko improved the codes as you suggested and this is committed. See SVN REV 1649. Note: We have not changed, as suggested, specific names DMAX1 etc, to generic MAX. It will better to do this kind of change consistently over all routines. So we will fix zgejsv, zgesvj, zgsvj0, and zgsvj1 for DMAX1, and etc in a later commit. I will follow up on this. Best wishes, Julien.