Incorrect LAPACK/BLAS uppercase symbols

Open discussion for MAGMA

Incorrect LAPACK/BLAS uppercase symbols

Postby evanlezar » Wed May 16, 2012 12:24 pm

It seems that the external lapack and blas symbols where all translated from the complex double precision case, and as such, the names mangled using the
Code: Select all
FORTRAN_NAME

macro in magma_[csd]lapack.h are not consistent.

For example, magma_slapack.h contains
Code: Select all
#define blasf77_saxpy      FORTRAN_NAME( saxpy,  ZAXPY  )
#define blasf77_scopy      FORTRAN_NAME( scopy,  ZCOPY  )

instead of
Code: Select all
#define blasf77_saxpy      FORTRAN_NAME( saxpy,  SAXPY  )
#define blasf77_scopy      FORTRAN_NAME( scopy,  SCOPY  )


I am busy fixing these and can provide a patch if required.

Thanks.
Evan
evanlezar
 
Posts: 33
Joined: Tue Aug 25, 2009 7:20 pm
Location: Stellenbosch, South Africa

Re: Incorrect LAPACK/BLAS uppercase symbols

Postby mgates3 » Wed May 16, 2012 2:08 pm

Yes, we code most functions in double complex and automatically convert to the other precisions. The inconsistencies for uppercase names are an oversight; I will fix our automated script to convert these.

-mark
mgates3
 
Posts: 438
Joined: Fri Jan 06, 2012 2:13 pm

Re: Incorrect LAPACK/BLAS uppercase symbols

Postby evanlezar » Wed May 16, 2012 3:28 pm

Thanks.

Also, keep up the great work!
evanlezar
 
Posts: 33
Joined: Tue Aug 25, 2009 7:20 pm
Location: Stellenbosch, South Africa

Re: Incorrect LAPACK/BLAS uppercase symbols

Postby mgates3 » Wed May 30, 2012 10:26 am

This has been fixed and will be in the next release. Thanks for pointing it out.
-mark
mgates3
 
Posts: 438
Joined: Fri Jan 06, 2012 2:13 pm

Re: Incorrect LAPACK/BLAS uppercase symbols

Postby evanlezar » Wed May 30, 2012 10:31 am

Thanks Mark,

I also sent a patch to Stan and Mathieu containing this and a couple of other fixes.

I have not received any notification that they got this. Should I send this on to you as well?

Evan
evanlezar
 
Posts: 33
Joined: Tue Aug 25, 2009 7:20 pm
Location: Stellenbosch, South Africa


Return to User discussion

Who is online

Users browsing this forum: Bing [Bot] and 2 guests