Changes in RC4

Open discussion for MAGMA

Changes in RC4

Postby fletchjp » Tue Mar 08, 2011 6:17 pm

I wonder if someone would summarise for us the changes in RC4 so that we know where to direct testing.

I have already noticed that a directory called quark has disappeared and there is a new one called control.

I notice that the makefile still included references to quark as a source of headers to include, which is presumably redundant.

Thanks

John
fletchjp
 
Posts: 175
Joined: Mon Dec 27, 2010 7:29 pm

Re: Changes in RC4

Postby mateo70 » Tue Mar 08, 2011 8:21 pm

Hi,

I won't enter into details, but quark should have not appear into the previous release. The new directory control contains all the workaround of MAGMA and will contains the future functions for initialisation of MAGMA library in a context for using different cards for example or multi-threaded code like it appeared in RC3.
So because this code was too much "work in progress" I removed it from the release and won't be part of the final 1.0.0.

The others changes are the final integration of the eigenvalues solvers and a lot of cleanings in the f2c code used in these solvers and other small changes like :
- consistency of types: cuDoubleComplex and cuFloatComplex are used everywhere now.
- consistency of the interface of all the functions.
- try to clean most of the return values in lapack functions
- finish to clean interface and code of eigenvalues problem
- integration of some bug report for windows port: multiple definition of min, max, problem with int64_t, problem with threads under windows but not used anymore for this release.

Mathieu
mateo70
 
Posts: 41
Joined: Tue Mar 08, 2011 12:38 pm

Re: Changes in RC4

Postby fletchjp » Wed Mar 09, 2011 5:55 am

Thanks.

John
fletchjp
 
Posts: 175
Joined: Mon Dec 27, 2010 7:29 pm

Re: Changes in RC4

Postby fletchjp » Wed Mar 09, 2011 6:01 pm

Something has changed in the FORTRAN interface. Calls to magma_dgetrf_gpu and magma_dgetrs_gpu don't compile for rc4. The type of an argument has changed from a pointer to real.

Yes. Looking in testing_dgetrf_gpu_f.f at the definition of the variable used to allocate GPU memory:

In RC3

Code: Select all
      integer(kind=16)              :: devptrA, devptrB


In RC4

Code: Select all
      real, dimension(4)            :: devptrA, devptrB


This has broken my code. Making the above change restores it.

Also, the change means that something which did not work now works. Hooray!!

I was getting nan instead of results, and now it works.

John
fletchjp
 
Posts: 175
Joined: Mon Dec 27, 2010 7:29 pm

Re: Changes in RC4

Postby mateo70 » Tue Mar 15, 2011 5:20 pm

Yes , sorry I forgot this change, since I didn't do it.
I have to check why it doesn't work with the size of a pointer (integer kind=8 on 64bits system or integer kind=4 for 32bits system) which should be the right choice for this. And we change it to this value because some compiler were not happy with the kind=16.

Mathieu
mateo70
 
Posts: 41
Joined: Tue Mar 08, 2011 12:38 pm

Re: Changes in RC4

Postby fletchjp » Wed Mar 16, 2011 8:54 am

It makes it impossible to do pointer arithmetic on it - see my other post on this.

John
fletchjp
 
Posts: 175
Joined: Mon Dec 27, 2010 7:29 pm


Return to User discussion

Who is online

Users browsing this forum: Bing [Bot] and 3 guests